Repository navigation
Add configurable datum LLH transformation using PROJ - #104
Merged
Merged
Conversation
flipflip8952
self-requested a review
February 2, 2026 11:30
flipflip8952
previously approved these changes
Feb 2, 2026
Closed
flipflip8952
force-pushed
the
feature/proj
branch
from
June 4, 2026 08:27
195c17e to
6c693a2
Compare
flipflip8952
force-pushed
the
feature/proj
branch
from
July 16, 2026 09:23
e450f2e to
9a5a700
Compare
flipflip8952
marked this pull request as draft
August 3, 2026 19:39
fgarciacardenas
force-pushed
the
feature/proj
branch
3 times, most recently
from
September 14, 2026 12:42
d6e8ff6 to
f76acfc
Compare
fgarciacardenas
marked this pull request as ready for review
September 14, 2026 13:01
flipflip8952
requested changes
Sep 15, 2026
flipflip8952
left a comment
Contributor
There was a problem hiding this comment.
Let's discuss. I'm not sure I agree with the implementation.
flipflip8952
force-pushed
the
feature/proj
branch
from
October 28, 2026 16:49
f76acfc to
b2abf6e
Compare
Simplify LlhTransformer thread safety Create the PROJ state once in Init() and use a mutex for the transforms, instead of per-thread PROJ state. Only the driver worker thread transforms coordinates, so per-thread state is not necessary. Use SDK Transformer for datum LLH, remove LlhTransformer The SDK Transformer now has the options, CRS checks and thread safety that LlhTransformer had. The driver keeps only the policy: InitLlhTrafo() checks the CRS types, EcefToLlhRad() falls back to the built-in WGS84 conversion if datum LLH is disabled. Without PROJ (FPSDK_USE_PROJ=0) the driver uses the built-in WGS84 conversion and rejects datum LLH enabled. The driver no longer links PROJ directly. Use BUILD_TESTING for fixposition_driver_lib tests Use include(CTest) and BUILD_TESTING (default ON) instead of FPSDK_BUILD_TESTING. Build the tests only if GTest is available. Load ROS1 datum_llh params only if the namespace exists If datum_llh is present, all its params are required. If it is absent, the defaults stay. Remove LoadOptionalRosParam().
flipflip8952
force-pushed
the
feature/proj
branch
from
October 29, 2026 09:33
4e69589 to
0dc7bdd
Compare
flipflip8952
requested review from
flipflip8952 and
joaomsbernardino
and removed request for
flipflip8952 and
joaomsbernardino
October 29, 2026 10:50
flipflip8952
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes (if datum_llh.enabled = true, i.e. using transformations):
geographic 2D + vertical.
See https://docs.fixposition.com/fd/custom-geodetic-datum-and-orthometric-height for the documentation